Skip to content

Add paths and folders to be export-ignored to .gitattributes #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

michaeldyrynda
Copy link
Contributor

Add paths to .gitattributes with the export-ignore flag set, so they're not pulled down as part of a project's dependencies via Composer.

@bsweeney
Copy link
Member

bsweeney commented Oct 18, 2021

Didn't want to exclude the sample-fonts and folders as well?

@michaeldyrynda
Copy link
Contributor Author

Didn't check that they were only being used for tests; have added them, too 👍

@bsweeney
Copy link
Member

I saw my comment was an unfinished "sample-fonts and" ... like I was going to say something else and forgot. And I was, did you want to exclude the tests folder as well?

@michaeldyrynda
Copy link
Contributor Author

Gosh, literally the whole reason I set out to create this PR in the first place 🤦


/.gitattributes export-ignore
/.gitignore export-ignore
/.travis.yml export-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI travis.yml is no longer part of the library

@bsweeney bsweeney merged commit 8e8fbc4 into dompdf:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants